I'm leaving this here because it gets asked every new release and many people run into the bug and get confused when the system reboots after sysupgrade and can't finish booting. This issue affects a lot of modern Thinkpads and other semi-modern laptop hardware due to all the firmware/binary blobs involved with EFI and other misc. things on them beyond the control of the OpenBSD developers.
### The BUG
After running
sysupgrade
The sysupgrade(8) tool will download the new kernel+base sets from whatever mirror you're using then it will reboot the system. Your system will go through POST after reboot, prompt for password to decrypt the SSD/HDD (if you use FDE) then detect the new kernel at the
boot>
prompt and either automatically attempt to run the kernel update after a short time or you can manually start by pressing return key.
So what happens is on may modern Thinkpads/laptops it'll start probing for hardware and get stuck here:
scsibus0 at <something>: 256 targets
Then it'll refuse to go any further. There are reports on the mailing lists that some machines can eventually pass through this freeze if you let them sit for 24-48+ hours. But I've personally never had the free time to let the machine sit idle that long to figure out if it'll work on my Thinkpad T14 Gen 1. Hence why I haven't sent a dmesg or filed a bug report even after dealing with this for two-three years now.
######## How to work around this issue
So what you'll want to do is shutdown/power down the machine. In other words; power cycle it aka turn it off and on again. If you do this and attempt booting again something in the firmware gets properly initialized and the hardware/disk can be properly brought up during the upgrade and the process will complete like it should. If you've already used sysupgrade(8) and gotten stuck just power cycle the machine. But if you want to avoid it in the future when using the tool invoke it with the "-n" flag then manually run
shutdown -p now
Afterwards. The -n flag with sysupgrade instructs it to download the new kernel+base system sets to your /home/_sysupgrade directory but it does not automatically reboot the machine once the files have finished downloading. This way you can manually issue the shutdown(8) afterwards at your convenience. Then you can avoid the whole having to forcefully hold down the power button on your machine during POST/where it gets hung during boot when attempting to search for /bsd.upgrade on disk.
So on my machine running -current it looks like this:
I run:
doas sysupgrade -s -n
To download the latest current snapshot from the mirror I have set-up in /etc/installurl
After that once I have a chance to close/save my work in EDITOR and close stuff like my open browser I issue the command
doas shutdown -p now
Which will shutdown the system of course. Then I manually power it back on with the power button. Enter my password to decrypt the SSD when prompted. It detects /bsd.upgrade and installs the new kernel+base system sets. Then reboots on its own (which will work without hanging, at least on my machine). Enter my decryption password again and go through boot process until graphical log-in comes up. Log-in as my user account and I'm back in business since all my stuff like emacs, tmux session etc. auto launches based on configuration in my ~ directory.
This was pretty annoying the first time I ran into it on this new laptop. I've been wanting to track down the root cause for over two years now but again. I just haven't had time to wait around 24-48+ hours to see if it would finally pass through whatever is blocking it (I assume the machine's firmware/BIOS) to get any logs worth sending in as a bug report.
If any of you guys around here smarter than myself might know what may be causing this or how I could get logs without waiting 1-2 days and praying I'm all ears.
I hope someone with a newer thinkpad or Apple laptop (or any others that might suffer from this issue) will find this useful in the future. Other than this one issue and a minor issue with left mouse button not "waking up" properly after suspending to RAM I have no other major bugs with this particular machine. The mouse not waking up is usually as simple as running
zzz
Again and resuming. Typically, second time it wakes up the button comes back and functions just fine until I use zzz again. I think ZZZ might still be broken on this particular machine but I haven't attempted to suspend to SSD in over a year now.
Hope this was helpful.